I've updated the code and submitted the PR: J
On Monday, 13 April 2015 17:12:38 UTC+2, Jeremy Evans wrote: > > On Sunday, April 12, 2015 at 11:19:53 PM UTC-7, Jurgens du Toit wrote: >> >> Hey >> >> I've updated the suggested changes: >> https://github.com/jeremyevans/sequel/compare/master...jrgns:odbc-bit-is-boolean >> >> This doesn't have an effect on the date / time conversions, and I've >> enabled the tests for boolean types. >> >> I tried looking at the use_time option that ODBC provides, but the effect >> it has is a bit above my paygrade and time constraints. I'll try again when >> I have more time. >> > > This looks OK, but instead of modifying the case statement, I'd just > handle the SQL_BIT handling in the else branch of the case statement. > After that, it should be ready to test and merge. > > Thanks, > Jeremy > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
