On Thursday, April 14, 2016 at 1:26:49 PM UTC-7, Caio Chassot wrote: > > > I don't think we should make this the default behavior, but I'm not >> opposed to adding a connection pool option that will use threads to >> preconnect. Please send a pull request if you would like that behavior, >> making sure to handle both the sharded and regular threaded connection >> pools. >> > > Let me know if this looks good and I'll open the PR: > > > https://github.com/jeremyevans/sequel/compare/master...kch:preconnect-concurrently > >
Thanks! This looks good, though I would make a minor change to only support either :concurrent or :concurrently instead of supporting both. Also, the addition to the connection pool specs seem to only test the sharded threaded pool and not the regular threaded pool or the single connection pools, unless I missed something. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
