On Thursday, April 14, 2016 at 6:05:38 PM UTC-7, Caio Chassot wrote: > > Also, the addition to the connection pool specs seem to only test the >> sharded threaded pool and not the regular threaded pool or the single >> connection pools, unless I missed something. >> > > Yup guess I missed those, fixed. >
Changes look good, thank you. > wrt the single-threaded pool, I didn't implement the concurrent behavior > (I just ignore the argument) in those because I assumed it would be > undesirable. I.e. one's using a single-threaded pool because working with a > single-threaded app. Or should they also have concurrent behavior? What do > you think? > I agree, I don't think anyone would want concurrent behavior in the single threaded pool. You just want to make the API compatible and test for that. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
