Hi Jeremy, I'm trying to submit the PR, but I'm trying to run the specs for :mysql2:
if DB.adapter_scheme == :mysql2 Do you know how I can get these specs to trigger? If I run rake spec_mysql I get an error: rake spec_mysql /Users/aryk/.rvm/rubies/ruby-2.4.1/bin/ruby spec/adapter_spec.rb mysql /Users/aryk/Development/contributions/sequel/lib/sequel/database/connecting.rb:70:in `connect': Sequel::Database.connect takes either a Hash or a String, given: nil (Sequel::Error) But I can run rake spec just fine, so I can just stick to that. On Monday, July 3, 2017 at 6:30:04 PM UTC-7, Aryk Grosz wrote: > > Hi Jeremy, I think I might PR that. Would love to contribute. > > In addition to this, I noticed in your paged_each code you do not call > "all" after applying the limit and offset. Wouldn't this bypass calling > #eager and then paged_each? > > Any reason for this? How do you recommend I get the benefits of eager with > paged_each? > > Aryk > > On Sunday, June 25, 2017 at 9:23:43 AM UTC-7, Jeremy Evans wrote: >> >> On Sunday, June 25, 2017 at 2:20:54 AM UTC-7, Aryk Grosz wrote: >>> >>> Hi Jeremy, >>> >>> Would it be possible to give a way to overwrite the >>> "STREAMING_SUPPORTED" variable in the mysql2 adapter with an option in >>> paged_each? >>> >>> That way, we could still use paged_each, but use the normal limit, >>> offset approach found in other orms. Wouldn't this resolve the issues that >>> happen due to mysql streaming? >>> >> >> That's pretty simple to do. Maybe just a :stream=>false option, and if >> that is present, call super instead of using streaming? If you'd like to >> see that, please submit a pull request. >> >> Thanks, >> Jeremy >> > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
