Ok, got it working. FYI, had some failures due to sql_mode being defaulted. Not sure if specs should be agnostic to sql_mode settings on mysql. I guess that's a different topic.
Here is the PR: https://github.com/jeremyevans/sequel/pull/1395 Aryk On Monday, July 3, 2017 at 8:01:42 PM UTC-7, Jeremy Evans wrote: > > On Monday, July 3, 2017 at 6:59:24 PM UTC-7, Aryk Grosz wrote: >> >> Hi Jeremy, I'm trying to submit the PR, but I'm trying to run the specs >> for :mysql2: >> >> if DB.adapter_scheme == :mysql2 >> >> >> Do you know how I can get these specs to trigger? >> >> If I run rake spec_mysql I get an error: >> >> rake spec_mysql >> >> /Users/aryk/.rvm/rubies/ruby-2.4.1/bin/ruby spec/adapter_spec.rb mysql >> >> /Users/aryk/Development/contributions/sequel/lib/sequel/database/connecting.rb:70:in >> >> `connect': Sequel::Database.connect takes either a Hash or a String, given: >> nil (Sequel::Error) >> >> But I can run rake spec just fine, so I can just stick to that. >> > > > You need to set SEQUEL_INTEGRATION_URL or SEQUEL_MYSQL_URL environment > variables, or modify spec/spec_config.rb to set the DB constant. See the > testing guide: > http://sequel.jeremyevans.net/rdoc/files/doc/testing_rdoc.html#label-Testing+Sequel+Itself > > Thanks, > Jeremy > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
