On Tuesday, July 11, 2017 at 8:06:35 AM UTC-7, [email protected] wrote: > > > > On Tuesday, July 11, 2017 at 16:57:45 UTC+3, Jeremy Evans wrote: >> >> On Tuesday, July 11, 2017 at 6:49:37 AM UTC-7, [email protected] wrote: >>> >>> > >> So, here is my question: >>> What would be appropriate place to check the version for database server >>> and enable new limit/offset syntax if database supports it? >>> >> >> There is already code for getting the database version. Overriding >> Dataset#select_limit_sql in the shared oracle adapter is probably the best >> way to enable the limit/offset syntax if the database version is high >> enough, but you'll also need to disable the emulation in select_sql in that >> case. Check the shared mssql adapter for a similar change (MSSQL <2012 >> needs offset emulation, 2012+ does not). Guess I'll need to setup an Oracle >> 12 VM so I can start testing it. :) >> >> > I have implemented the change and testing it with my code > The branch is here: > https://github.com/timon/sequel/tree/feature/oracle-12-limit-offset > Your review would be highly appreciated >
I left some comments on the commits, as I think a different approach would be simpler. Have you tried running `rake spec_oracle` with the changes? That's probably the best way to test. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
