On Tuesday, July 11, 2017 at 9:45:57 AM UTC-7, [email protected] wrote: > > > > On Tuesday, July 11, 2017 at 18:38:14 UTC+3, Jeremy Evans написал: >> >> I have implemented the change and testing it with my code >>> The branch is here: >>> https://github.com/timon/sequel/tree/feature/oracle-12-limit-offset >>> Your review would be highly appreciated >>> >> >> I left some comments on the commits, as I think a different approach >> would be simpler. >> > Thanks. I've created pull request to master branch of my fork, because I > find it's easier to keep track of discussion that way. > > >> Have you tried running `rake spec_oracle` with the changes? That's >> probably the best way to test. >> > > Our database is shared among many developers, so I'd like to know what > kind of setup is required to run the specs. > Then our DBAs perhaps could arrange setup for testing >
You definitely need to run the specs in their own database. Oracle offers development VMs that should be suitable: http://www.oracle.com/technetwork/community/developer-vm/index.html Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
