On Thursday, May 10, 2018 at 1:43:33 PM UTC-7, Jeremy Evans wrote: > > On Thursday, May 10, 2018 at 12:51:23 PM UTC-7, ro...@affinity.co wrote: >> >> Awesome, we just upgraded to the latest version of Sequel, pretty >> seamless upgrade :) . Let us know if you have any updates on your end. >> > > That's great to hear that your upgrade was easy. > > I've got the fix all prepared, I'm just doing some final testing now. > I've decided to modify the threaded connection pools so that > disconnect_connection is never called while holding the connection pool > mutex. Previously, it could be called both while holding the mutex and > while not holding it. However, there is a chance that > disconnect_connection could block, so it's better if it is never called > while holding the mutex. Making that change fixed the recursive locking > issue, so a separate mutex inside the connection_validator and > connection_expiration extensions is not needed. >
OK, commit pushed to master, please test and let me know whether this fixes the issue: https://github.com/jeremyevans/sequel/commit/0db9e0097eb3b198a149f750dbef22328bc2e73a Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to sequel-talk+unsubscr...@googlegroups.com. To post to this group, send email to sequel-talk@googlegroups.com. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
