On Thursday, November 8, 2018 at 9:33:35 AM UTC-8, Ben Alavi wrote: > > Realized we could get rid of the need to use the explicit table_map option > to CTI w/ a qualified dataset *if we can assume that the subclasses are > qualified the same way as the superclass*. It seems like a more > reasonable default assumption than that they are not using the same > qualifier, and can still use the table_map to get around it if needed. > > I wasn't sure if this was the best way to get the superclass' qualifier, > but the following patch adds a spec and passes: > > If it looks good and my assumption makes sense I'll submit a PR or make > changes. >
I think it is a better assumption. However, it could break backwards compatibility in the case where the parent table is qualified but the child table is not, so I don't think we can switch to it (until at least Sequel 6). We could add an option to support the behavior, though. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
