[ 
https://forge.continuent.org/jira/browse/SEQUOIA-1050?page=comments#action_14325
 ] 

Emmanuel Cecchet commented on SEQUOIA-1050:
-------------------------------------------


  public void setShutdownCheckpoint()
  {
    RecoveryLog recoveryLog = requestManager.getRecoveryLog();
    if (recoveryLog != null)
      try
      {
        recoveryLog
            .storeCheckpoint("shutdown" + controller.getControllerName());
      }
      catch (SQLException e)
      {
        logger.warn("Error while setting shutdown checkpoint", e);
      }
  }


Should be fixed with:


  public void setShutdownCheckpoint()
  {
    RecoveryLog recoveryLog = requestManager.getRecoveryLog();
    if (recoveryLog != null)
      try
      {
        recoveryLog
            .storeCheckpoint(buildCheckpointName("shutdown"));
      }
      catch (SQLException e)
      {
        logger.warn("Error while setting shutdown checkpoint", e);
      }
  }


> Duplicate shutdown checkpoint names with non-distributed virtual databases
> --------------------------------------------------------------------------
>
>          Key: SEQUOIA-1050
>          URL: https://forge.continuent.org/jira/browse/SEQUOIA-1050
>      Project: Sequoia
>         Type: Bug

>   Components: Recovery Log, Core
>  Environment: Any non-distributed virtual database with recovery log
>     Reporter: Emmanuel Cecchet
>     Assignee: Emmanuel Cecchet
>     Priority: Critical

>
>
> The code in VirtualDatabase.setShutdownCheckpoint does not generate unique 
> checkpoint names. Shutting down the controller for the second time on the 
> same controller will generate a duplicate entry exception in the recovery log.
> The method should use buildCheckpointName("shutdown") instead like in the 
> DistributedVirtualDatabase implementation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://forge.continuent.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

_______________________________________________
Sequoia mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/sequoia

Reply via email to