+1>
Mainly for the supplied matchers and mailets, adding protected getter/setter methods.
+1
This is a very sound and clean initiative. We should perhaps also write a "mailet/matcher coding best practices" wiki page.
+1
"Also, while making this change it might be worth considering adding a prefix to the variable names, 'field' is typical. So... ... This has two advantages. Firstly, it avoids mistaken direct access to the variable and secondly it makes the class JavaBean compatible..."
+1 for the first reason, but I think that it is JavaBean compatible even without the renaming.
+0. I've seen this.name = name cause problems, so whatever workaround makes the coder doing it happy. Dunno if it's worth refactoring existing stuff.
-- Serge Knystautas President Lokitech >> software . strategy . design >> http://www.lokitech.com p. 301.656.5501 e. [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
