+1 in general. just minor comments below. On 8/19/05, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > 2) Deprecate/Remove unused methods from common interfaces: e.g. MailServer > provides 4 sendMails methods but only 1 is used from SMTPHandler and > MessageProcessor. The other 3 methods are always accessed via the > MailetContext interface (provided by the same component: James).
How do you deprecate/remove the unused methods when they are used by the mailetcontext API? Sounds like you understand the dependencies... I'm just a bit confused about how the change. > 3) Remove the inboundSpool concept from the MailStore by promoting the > "inbound" SpoolRepository to a toplevel block that James and > JamesSpoolManager will depend on. 2 advantages: possibility to implement > multiple spoolmanagers with multiple spoolrepositories, limit the > interdependencies of components (the Spoolmanager does not need the full > MailStore but only the inbound spoolrepository). Sounds good. Makes sense that there is one (core) inbound repository. Only concerned about confusing or duplicated conf file stuff. > 4) Promote MailetLoader and MatcherLoader to block components: this allow us > to make them easily configurable and allow to limit the knowledge needed by > the SpoolManager (the spoolmanager itself does not need the MailetContext > knowledge). To do that we need to change the Loaders to be Serviceable and > to remove the MailetContext parameter from the load calls. Hmm, this sounds rather pervasive change since I believe it affects where you would configure the processor chains. I'd like to understand how this would affect the conf file. > I would like to know if any committer is against this kind of changes. Again +1 in general. Just would like a bit more specifics since I'm too lazy/busy to think through how some of these changes affect other parts. -- Serge Knystautas Lokitech >> software . strategy . design >> http://www.lokitech.com p. 301.656.5501 e. [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
