Hi Joachim,
At a first look you did a really good job!
I have 2 questions:
1) Why you introduced the StoreAware interface? It seems it is not used
in the code.
2) Is there any javamail store implementation (even not maildir) under a
compatible license that we can use for the examples in the config.xml
and for the default tests? Imho the code you provided in the src folder
can be included in James, but the patch to config.xml and the tests
references the "maildir store" and the only known (to me) implementation
of the maildir store is GPL, so it would be safer for us to avoid even
this "virtual" references in our codebase.
Stefano
Joachim Draeger (JIRA) wrote:
[ http://issues.apache.org/jira/browse/JAMES-461?page=all ]
Joachim Draeger updated JAMES-461:
----------------------------------
Attachment: JavamailStoreMailRepository2.zip
This proposal has no other dependencies than Javamail (i think even before 1.4)
and James.
HashJavamailStoreMailRepository should work with every JavamailStore
implementation that has deterministic
message content. (checksum save). Performance could be quite good because
after storing/listing it tries to get the messages by the last seen message
number.
UIDPlusFolderMailRepository depends on javamail Folders that have a public
long[] addUIDMessages(Message[] msgs); method which returns the uids of the
added messages. This method is called via reflection, and in the future even
the message name might be configureable form config.xml.
At the moment there is no known Javamail store implementation that provides
such a method, but it should come soon.
The Javamail store url is not configureable in the unit tests at the moment.
Nearly all tests depend on getNativeMessageCount(), and getNativeMessages() at
the moment. I plan to write a few more general tests in the future.
This implementation should be considered as EXPERIMENTAL, but I think it's not
so far from being stable.
Joachim
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
