Yes.

If you look in the svn history of that file you will see that there was much worst bug about this. Maybe this was neven called anyway because the streams were always correctly closed by James.

Imho, the fact that it is (and has been) so buggy is a +1 to remove it and eventually investigate bugs introduced removing that outdated code instead of loosing much more time fixing that code itself.

Stefano

Bernd Fondermann (JIRA) wrote:
[ http://issues.apache.org/jira/browse/JAMES-512?page=comments#action_12413858 ]
Bernd Fondermann commented on JAMES-512:
----------------------------------------

shouldn't this

                for( int i = 0; i < size; i++ )
                {
                    IOUtil.shutdownStream( (OutputStream)list.get( 0 ) );
                }

be

                for( int i = 0; i < size; i++ )
                {
                    IOUtil.shutdownStream( (OutputStream)list.get( i ) );
                }

seems like this is not closing stream 1..(size-1)!


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to