On Sun, Aug 23, 2009 at 7:51 PM, Norman Maurer<[email protected]> wrote: > Hi Robert, > > I'm not sure if I like the idea of moving all this methods to the > SMTPSession. Things like the HelloName etc seems to make more sense to > resist in the ConfigurationData.These are stuff which belongs to the > config and will never change in the SMTPSession.
i agree i would prefer to move all information that is set at configuration time out from SMTPSession these were included in the SMTPSession indirectly by the configuration getter and are accessed as if they might change. the configuration getter hide these references and prevented this being sorted out properly. one option would be to move the static configuration into a POJO (SMTPConfiguration, say) and either use injection or a configuration interface. opinions? - robert --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
