Im still thinkin we should just inject the "full" service if its needed.
Bye, Norman 2009/8/23 Robert Burrell Donkin <[email protected]>: > On Sun, Aug 23, 2009 at 7:51 PM, Norman Maurer<[email protected]> wrote: >> Hi Robert, >> >> I'm not sure if I like the idea of moving all this methods to the >> SMTPSession. Things like the HelloName etc seems to make more sense to >> resist in the ConfigurationData.These are stuff which belongs to the >> config and will never change in the SMTPSession. > > UserRepository and MailServer are coursely grained services. i've been > taking a look at what's actually used from each. > > UserRepository: > boolean contains(String name) > boolean test(String name, String password) > > MailServer > boolean isLocalServer(String serverName); > String getId(); > String getDefaultDomain(); > > so most of the calls in these services aren't used > > the full services or new, more finely grained APIs could be injected, > or these calls could just be pushed into the session > > opinions? > > - robert > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
