Hi Eric, thx for the patch. could you please create a jira issue and attach the patch there? Be sure to check the grant asl2 box after uploading.
Thx Norman 2010/5/9, Eric Charles <eric.char...@u-mangate.com>: > Hi Norman, > > The patch is here after. > > A quick scan of the code shows that only only UsersRepository interface > is used (JamesUsersRepository that adds alias and forward is no more > used - but as we rely now on mappings, this should give no functinality > loose). > > I checked that users defined with LocalJamesUsersRepository were still > available and working after changing to LocalJamesUsersRepository > (needed for people already using trunk). > > Tks, > > Eric > > > Index: src/main/config/james/spring-beans.xml > =================================================================== > --- src/main/config/james/spring-beans.xml (revision 942302) > +++ src/main/config/james/spring-beans.xml (working copy) > @@ -238,14 +238,18 @@ > </bean> > > <!--This is needed to link the smtpserver to the local user repository > - LocalJamesUsersRepository is used for backward compatibility with > - James 2.3.0 > - If backward compatibility is not need the LocalUsersRepository > - implementation > + org.apache.james.impl.jamesuser.LocalJamesUsersRepository can > be used for > + backward compatibility with James 2.3.0 > + If backward compatibility is not needed, > org.apache.james.impl.user.LocalUsersRepository > + implementation is used by default. > --> > - <!-- could be safely used --> > + > + <!-- uncomment this for james 2.3.0 backward compatibility > <bean id="localusersrepository" > class="org.apache.james.impl.jamesuser.LocalJamesUsersRepository" /> > + --> > > + <!-- this is the default implementation for the localusersrepository - > not james 2.3.0 backward compatible --> > + <bean id="localusersrepository" > class="org.apache.james.impl.user.LocalUsersRepository" /> > > <!-- The context FileSystem implementation --> > <bean id="filesystem" > class="org.apache.james.container.spring.SpringFileSystem" /> > > > > > > > On 05/08/2010 05:28 AM, Norman Mauer wrote: >> >> +1, >> >> makes sense.. How about a patch ;) ? >> >> Thx, >> Norman >> >> >> 2010/5/5 Eric Charles<eric.char...@u-mangate.com>: >> > Hi, >> > >> > I understand org.apache.james.impl.jamesuser.LocalJamesUsersRepository >> > should be used for 2.3 compatibility and >> > org.apache.james.impl.user.LocalUsersRepository for fresh 3 >> > installations. >> > >> > Is this the case ? >> > >> > Tks, >> > >> > Eric >> > >> > PS1 : Comment in spring-beans.xml could mention the full classpath >> > (org.apache.james.impl.user.LocalUsersRepository) to avoid any >> > ambiguity. >> > PS2 : Default for our coming M1 release could be >> > org.apache.james.impl.user.LocalUsersRepository, migrating from 2.3 to >> > 3 >> > being a story still to be written. >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail:server-dev-unsubscr...@james.apache.org >> For additional commands, e-mail:server-dev-h...@james.apache.org >> >> >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
