[ https://issues.apache.org/jira/browse/IMAP-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882567#action_12882567 ]
Norman Maurer commented on IMAP-164: ------------------------------------ I agree with the @Column(uniqe=true) here... Changing the save(...) method is really bad IMHO, sometimes you dont want to commit until every save is complete. I will think about the MailboxExistsException a bit and see if I can figure out something useful. Till then just let us stick to the current code + annotation. > Move mailboxExists to MailboxMapper interface > --------------------------------------------- > > Key: IMAP-164 > URL: https://issues.apache.org/jira/browse/IMAP-164 > Project: JAMES Imap > Issue Type: Improvement > Components: Mailbox > Reporter: Tim-Christian Mundt > Priority: Minor > Attachments: existsViaFindByName.patch > > > The method MailboxMapper.countMailboxesWithName(mailboxName) is > only ever used in StoreMailboxManager.mailboxExists(mailboxName, > session). There the result is checked for duplicates. Duplicates should > be detected before writing and not when reading, for some stores (e.g. > maildir) it is not even possible to have more than one mailbox with the > same name. So this is superfluous and should should be moved to > MailboxMapper.existsMailbox(mailboxName) which can provide a more > efficient existence test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org