[ https://issues.apache.org/jira/browse/IMAP-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882574#action_12882574 ]
Tim-Christian Mundt commented on IMAP-164: ------------------------------------------ With "leave everything as is" I only meant the second part. I'd still remove the countMailboxesWithName meaning to apply the patch. The StoreMailboxManager takes care of duplicates during creation, so I think you don't have to do anything additionally. > Move mailboxExists to MailboxMapper interface > --------------------------------------------- > > Key: IMAP-164 > URL: https://issues.apache.org/jira/browse/IMAP-164 > Project: JAMES Imap > Issue Type: Improvement > Components: Mailbox > Reporter: Tim-Christian Mundt > Assignee: Norman Maurer > Priority: Minor > Attachments: existsViaFindByName.patch > > > The method MailboxMapper.countMailboxesWithName(mailboxName) is > only ever used in StoreMailboxManager.mailboxExists(mailboxName, > session). There the result is checked for duplicates. Duplicates should > be detected before writing and not when reading, for some stores (e.g. > maildir) it is not even possible to have more than one mailbox with the > same name. So this is superfluous and should should be moved to > MailboxMapper.existsMailbox(mailboxName) which can provide a more > efficient existence test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org