I mostly agree with Norman. My main issue is with cross project dependency: if we split imap into "imap" and "mailstore" where imap uses mailstore but mailstore doesn't know anything about imap then I'm fine with james-server depending on the new "mailstore" product
That said I saw in past you always cared about dependencies, so I guess this is only a temporary refactoring toward a better solution. In that case just go ahead. :-) Stefano 2010/9/21 Norman Maurer <[email protected]>: > Hi Eric, > > I don't agree with you here.. IMHO the whole mailrepository stuff > should not be in imap tree. It should be in JAMES Server (were it was > before). I just think its plain wrong to have it in imap tree and it > give us nothing more then cross-project dependencies (imap-trunk > depends on james-server-trunk which depends on imap-trunk...) > > So I'm -1 to move it to imap. I think splitting the implementations > make sense but it should stay were it was. > > Bye, > Norman > > 2010/9/21 Eric Charles <[email protected]>: >> Hi Norman, >> I introduced dependency to core-function if mailbox-file and mailbox-jdbc by >> error. >> It is now removed. >> However, mailbox (now in imap tree) dependency to core-api is there, and >> sounds logic. >> Tks, >> Eric >> >> >> On 21/09/2010 18:45, Norman Maurer wrote: >>> >>> Why does this touch the imap tree? >>> >>> Bye >>> Norman >>> >>> 2010/9/21, [email protected]<[email protected]>: >>>> >>>> Author: eric >>>> Date: Tue Sep 21 16:37:09 2010 >>>> New Revision: 999491 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=999491&view=rev >>>> Log: >>>> Remove core-function project and its only remaining unused class >>>> MailStoreSpoolRepository. we spool via queue interface, and core could be >>>> limited to api and library btw (IMAP-1048) >>>> >>>> Removed: >>>> james/server/trunk/core-function/ >>>> Modified: >>>> james/imap/trunk/file/pom.xml >>>> james/imap/trunk/jdbc/pom.xml >>>> james/imap/trunk/parent/pom.xml >>>> james/server/trunk/pom.xml >>>> james/server/trunk/pop3server/pom.xml >>>> james/server/trunk/remotemanager/pom.xml >>>> james/server/trunk/spring-deployment/pom.xml >>>> >>>> Modified: james/imap/trunk/file/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/imap/trunk/file/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/imap/trunk/file/pom.xml (original) >>>> +++ james/imap/trunk/file/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -42,10 +42,6 @@ >>>> <artifactId>james-server-core-library</artifactId> >>>> </dependency> >>>> <dependency> >>>> -<groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -</dependency> >>>> -<dependency> >>>> <groupId>commons-configuration</groupId> >>>> <artifactId>commons-configuration</artifactId> >>>> </dependency> >>>> >>>> Modified: james/imap/trunk/jdbc/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/imap/trunk/jdbc/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/imap/trunk/jdbc/pom.xml (original) >>>> +++ james/imap/trunk/jdbc/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -42,10 +42,6 @@ >>>> <artifactId>james-server-core-library</artifactId> >>>> </dependency> >>>> <dependency> >>>> -<groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -</dependency> >>>> -<dependency> >>>> <groupId>junit</groupId> >>>> <artifactId>junit</artifactId> >>>> <scope>test</scope> >>>> >>>> Modified: james/imap/trunk/parent/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/imap/trunk/parent/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/imap/trunk/parent/pom.xml (original) >>>> +++ james/imap/trunk/parent/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -329,11 +329,6 @@ >>>> </dependency> >>>> <dependency> >>>> <groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -<version>${version.james-server}</version> >>>> -</dependency> >>>> -<dependency> >>>> -<groupId>org.apache.james</groupId> >>>> <artifactId>james-server-common-util</artifactId> >>>> <version>${version.james-server}</version> >>>> </dependency> >>>> >>>> Modified: james/server/trunk/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/server/trunk/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/server/trunk/pom.xml (original) >>>> +++ james/server/trunk/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -45,7 +45,6 @@ >>>> <module>domain-function</module> >>>> <module>core-library</module> >>>> <module>management</module> >>>> -<module>core-function</module> >>>> <module>imapserver</module> >>>> <module>smtpserver</module> >>>> <module>lmtpserver</module> >>>> @@ -479,11 +478,6 @@ >>>> </dependency> >>>> <dependency> >>>> <groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -<version>${project.version}</version> >>>> -</dependency> >>>> -<dependency> >>>> -<groupId>org.apache.james</groupId> >>>> <artifactId>james-server-pop3server</artifactId> >>>> <version>${project.version}</version> >>>> </dependency> >>>> >>>> Modified: james/server/trunk/pop3server/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/server/trunk/pop3server/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/server/trunk/pop3server/pom.xml (original) >>>> +++ james/server/trunk/pop3server/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -110,11 +110,6 @@ >>>> </dependency> >>>> <dependency> >>>> <groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -<scope>runtime</scope> >>>> -</dependency> >>>> -<dependency> >>>> -<groupId>org.apache.james</groupId> >>>> <artifactId>james-server-user-library</artifactId> >>>> <scope>runtime</scope> >>>> </dependency> >>>> >>>> Modified: james/server/trunk/remotemanager/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/server/trunk/remotemanager/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/server/trunk/remotemanager/pom.xml (original) >>>> +++ james/server/trunk/remotemanager/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -125,11 +125,6 @@ >>>> </dependency> >>>> <dependency> >>>> <groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -<scope>test</scope> >>>> -</dependency> >>>> -<dependency> >>>> -<groupId>org.apache.james</groupId> >>>> <artifactId>james-server-dnsserver-api</artifactId> >>>> <type>test-jar</type> >>>> <scope>test</scope> >>>> >>>> Modified: james/server/trunk/spring-deployment/pom.xml >>>> URL: >>>> >>>> http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/pom.xml?rev=999491&r1=999490&r2=999491&view=diff >>>> >>>> ============================================================================== >>>> --- james/server/trunk/spring-deployment/pom.xml (original) >>>> +++ james/server/trunk/spring-deployment/pom.xml Tue Sep 21 16:37:09 2010 >>>> @@ -328,10 +328,6 @@ >>>> </dependency> >>>> <dependency> >>>> <groupId>org.apache.james</groupId> >>>> -<artifactId>james-server-core-function</artifactId> >>>> -</dependency> >>>> -<dependency> >>>> -<groupId>org.apache.james</groupId> >>>> <artifactId>james-server-spring-common</artifactId> >>>> </dependency> >>>> <dependency> >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
