Re: svn commit: r999491 - in /james: imap/trunk/file/ imap/trunk/jdbc/ imap/trunk/parent/ server/trunk/ server/trunk/core-function/ server/trunk/pop3server/ server/trunk/remotemanager/ server/trunk/spring-deployment/

Thu, 23 Sep 2010 05:40:29 -0700 

Thx Eric,
I reviewed your changes and they look really good. I think putting diagrams up will make it easier to get started with james hacking. 

So go for it:)

Bye,
Norman

Am 22.09.2010 10:46, schrieb Eric Charles:

 Hi,

mailrepository classes and projects are now back in server.

It's now cleaner with own api, library, impl projects and no 
dependency of imap to server :)

Would be nice to review commits and give feedback. Many Tks in advance


To help, I have uploaded a little diagram I maintain with the fast 
evolving projects (atm, it's "continuous refactoring", it will be soon 
stable I hope)

http://people.apache.org/~eric/james/20100922/james-20100922.png

(I removed the dependencies lines and names are sometimes not exactly 
what's in trunk (apache-james- instead of james-apache-, 
mailetconainer instead of spool...)).
You can see mail-* family (in server) in parallel to mailbox-* family 
(now in imap) projects.



Btw, do you find useful to integrate such diagrams on james web 3 
website (developer part)?


Tks,

Eric

On 21/09/2010 21:05, Norman Maurer wrote:

Hi,

I think it would be hard to move them because you would need to
duplicate the lifecycle stuff too. I would be more in favor to just
move the classes / packages back to james-server.

Bye,
Norman


2010/9/21 Eric Charles<[email protected]>:

  Hi Stephano,

Yes, I saw it like a temporary situation evolving with 'mailrepository'

(2.3) and 'mailbox' (3.0) grouped into a 'mailstore' umbrella, just 
like

there are other umbrellas' ('server', 'imap',...).

In any case, it was planned to create this umbrella for all 3.0 mailbox
projects.

Now, the question is should 2.3 mailrepository be moved to this new 
umbrella

?

If yes, current trunk is ready for this migration.
If no, I will create 4 new projects (mail-api, mail-library, mail-file,
mail-jdbc) in server and they projects will stay there (not moved to
mailstore 'umbrella').


As I explained in the "What's in a store" thread, I would like to 
see the

2.3 and 3.0 storages bridges/adapted, this is why I looking more to the
migration to the new umbrella. But maybe the other solution has other
advantages ?

Tks,

Eric

On 21/09/2010 20:00, Stefano Bagnara wrote:

I mostly agree with Norman.

My main issue is with cross project dependency: if we split imap into
"imap" and "mailstore" where imap uses mailstore but mailstore doesn't
know anything about imap then I'm fine with james-server depending on
the new "mailstore" product

That said I saw in past you always cared about dependencies, so I
guess this is only a temporary refactoring toward a better solution.
In that case just go ahead. :-)

Stefano

2010/9/21 Norman Maurer<[email protected]>:

Hi Eric,

I don't agree with you here.. IMHO the whole mailrepository stuff
should not be in imap tree. It should be in JAMES Server (were it was
before). I just think its plain wrong to have it in imap tree and it
give us nothing more then cross-project dependencies (imap-trunk
depends on james-server-trunk which depends on imap-trunk...)

So I'm -1 to move it to imap. I think splitting the implementations
make sense but it should stay were it was.

Bye,
Norman

2010/9/21 Eric Charles<[email protected]>:

  Hi Norman,
I introduced dependency to core-function if mailbox-file and
mailbox-jdbc by
error.
It is now removed.

However, mailbox (now in imap tree) dependency to core-api is 
there, and

sounds logic.
Tks,
Eric


On 21/09/2010 18:45, Norman Maurer wrote:

Why does this touch the imap tree?

Bye
Norman

2010/9/21, [email protected]<[email protected]>:

Author: eric
Date: Tue Sep 21 16:37:09 2010
New Revision: 999491

URL: http://svn.apache.org/viewvc?rev=999491&view=rev
Log:
Remove core-function project and its only remaining unused class

MailStoreSpoolRepository. we spool via queue interface, and 
core could

be
limited to api and library btw (IMAP-1048)

Removed:
     james/server/trunk/core-function/
Modified:
     james/imap/trunk/file/pom.xml
     james/imap/trunk/jdbc/pom.xml
     james/imap/trunk/parent/pom.xml
     james/server/trunk/pom.xml
     james/server/trunk/pop3server/pom.xml
     james/server/trunk/remotemanager/pom.xml
     james/server/trunk/spring-deployment/pom.xml

Modified: james/imap/trunk/file/pom.xml
URL:



http://svn.apache.org/viewvc/james/imap/trunk/file/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/imap/trunk/file/pom.xml (original)
+++ james/imap/trunk/file/pom.xml Tue Sep 21 16:37:09 2010
@@ -42,10 +42,6 @@
<artifactId>james-server-core-library</artifactId>
</dependency>
<dependency>
-<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-</dependency>
-<dependency>
<groupId>commons-configuration</groupId>
<artifactId>commons-configuration</artifactId>
</dependency>

Modified: james/imap/trunk/jdbc/pom.xml
URL:



http://svn.apache.org/viewvc/james/imap/trunk/jdbc/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/imap/trunk/jdbc/pom.xml (original)
+++ james/imap/trunk/jdbc/pom.xml Tue Sep 21 16:37:09 2010
@@ -42,10 +42,6 @@
<artifactId>james-server-core-library</artifactId>
</dependency>
<dependency>
-<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-</dependency>
-<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>

Modified: james/imap/trunk/parent/pom.xml
URL:



http://svn.apache.org/viewvc/james/imap/trunk/parent/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/imap/trunk/parent/pom.xml (original)
+++ james/imap/trunk/parent/pom.xml Tue Sep 21 16:37:09 2010
@@ -329,11 +329,6 @@
</dependency>
<dependency>
<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-<version>${version.james-server}</version>
-</dependency>
-<dependency>
-<groupId>org.apache.james</groupId>
<artifactId>james-server-common-util</artifactId>
<version>${version.james-server}</version>
</dependency>

Modified: james/server/trunk/pom.xml
URL:



http://svn.apache.org/viewvc/james/server/trunk/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/server/trunk/pom.xml (original)
+++ james/server/trunk/pom.xml Tue Sep 21 16:37:09 2010
@@ -45,7 +45,6 @@
<module>domain-function</module>
<module>core-library</module>
<module>management</module>
-<module>core-function</module>
<module>imapserver</module>
<module>smtpserver</module>
<module>lmtpserver</module>
@@ -479,11 +478,6 @@
</dependency>
<dependency>
<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-<version>${project.version}</version>
-</dependency>
-<dependency>
-<groupId>org.apache.james</groupId>
<artifactId>james-server-pop3server</artifactId>
<version>${project.version}</version>
</dependency>

Modified: james/server/trunk/pop3server/pom.xml
URL:



http://svn.apache.org/viewvc/james/server/trunk/pop3server/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/server/trunk/pop3server/pom.xml (original)
+++ james/server/trunk/pop3server/pom.xml Tue Sep 21 16:37:09 2010
@@ -110,11 +110,6 @@
</dependency>
<dependency>
<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-<scope>runtime</scope>
-</dependency>
-<dependency>
-<groupId>org.apache.james</groupId>
<artifactId>james-server-user-library</artifactId>
<scope>runtime</scope>
</dependency>

Modified: james/server/trunk/remotemanager/pom.xml
URL:



http://svn.apache.org/viewvc/james/server/trunk/remotemanager/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/server/trunk/remotemanager/pom.xml (original)

+++ james/server/trunk/remotemanager/pom.xml Tue Sep 21 
16:37:09 2010

@@ -125,11 +125,6 @@
</dependency>
<dependency>
<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-<scope>test</scope>
-</dependency>
-<dependency>
-<groupId>org.apache.james</groupId>
<artifactId>james-server-dnsserver-api</artifactId>
<type>test-jar</type>
<scope>test</scope>

Modified: james/server/trunk/spring-deployment/pom.xml
URL:



http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/pom.xml?rev=999491&r1=999490&r2=999491&view=diff 





============================================================================== 


--- james/server/trunk/spring-deployment/pom.xml (original)

+++ james/server/trunk/spring-deployment/pom.xml Tue Sep 21 
16:37:09

2010
@@ -328,10 +328,6 @@
</dependency>
<dependency>
<groupId>org.apache.james</groupId>
-<artifactId>james-server-core-function</artifactId>
-</dependency>
-<dependency>
-<groupId>org.apache.james</groupId>
<artifactId>james-server-spring-common</artifactId>
</dependency>
<dependency>




--------------------------------------------------------------------- 


To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



--------------------------------------------------------------------- 


To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


--------------------------------------------------------------------- 


To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]























					Reply via email to