[
https://issues.apache.org/jira/browse/MAILBOX-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563772#comment-13563772
]
Eric Charles commented on MAILBOX-191:
--------------------------------------
I Peter,
I tried to apply the patch on mailbox trunk with 'patch -p0...', but got some
rejections.
Did you build it on the trunk version?
I am happy to give it more try based on your inputs.
The logic may be good, but I really want to run the mailbox integration tests.
Did you try to run those tests with your patch?
https://svn.apache.org/repos/asf/james/mailbox-integration-tester/trunk/
Also, always great to have unit tests that cover the class
StoreMessageResultIterator
Thx, Eric
> more effective implementation of StoreMessageResultIterator
> -----------------------------------------------------------
>
> Key: MAILBOX-191
> URL: https://issues.apache.org/jira/browse/MAILBOX-191
> Project: James Mailbox
> Issue Type: Improvement
> Components: store
> Affects Versions: 0.4, 0.5
> Reporter: Peter Kvokacka
> Priority: Minor
> Labels: patch
> Fix For: 0.5
>
> Attachments: StoreMessageResultIterator.java
>
>
> I found problem with current implementation of StoreMessageResultIterator. I
> discribed it here.
> http://www.mail-archive.com/[email protected]/msg14242.html
> Briefly:
> From Thunderbird I got request
> 452 UID fetch 16,17:18,20:41,43:45,47,49 (UID RFC822.SIZE BODY.PEEK[])
> which is mapped to calls on MessageMapper.findInMailbox()
> findInMailbox: TYPE: RANGE UID: 16:18, Full
> *findInMailbox: TYPE: FROM UID: 19:-1, Full
> findInMailbox: TYPE: RANGE UID: 20:41, Full
> *findInMailbox: TYPE: FROM UID: 42:-1, Full
> findInMailbox: TYPE: RANGE UID: 43:45, Full
> *findInMailbox: TYPE: FROM UID: 46:-1, Full
> findInMailbox: TYPE: ONE UID: 47:47, Full
> *findInMailbox: TYPE: ONE UID: 48:48, Full
> findInMailbox: TYPE: ONE UID: 49:49, Full
> Those marked calls of method findInMailbox are completely unnecessary and
> should be avoided.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
