[
https://issues.apache.org/jira/browse/MAILBOX-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570158#comment-13570158
]
Peter Kvokacka commented on MAILBOX-191:
----------------------------------------
Hi Eric
it seems that problem with rejections, that you got, was due to fact that
Eclipse on Windows produce patch with different end lines than patch created on
linux system via commad line. So I made one more patch for you now via command
line on linux. The patch is same as previous one's when it comes to logic. It
has just different end lines. I applied new patch to trunk on linux and I got
no rejections.
Hope it will work for you now.
I didn't have time to run integration tests. Let me know if some problem arise.
Peter
> more effective implementation of StoreMessageResultIterator
> -----------------------------------------------------------
>
> Key: MAILBOX-191
> URL: https://issues.apache.org/jira/browse/MAILBOX-191
> Project: James Mailbox
> Issue Type: Improvement
> Components: store
> Affects Versions: 0.4, 0.5
> Reporter: Peter Kvokacka
> Priority: Minor
> Labels: patch
> Fix For: 0.5
>
> Attachments: StoreMessageResultIterator.java
>
>
> I found problem with current implementation of StoreMessageResultIterator. I
> discribed it here.
> http://www.mail-archive.com/[email protected]/msg14242.html
> Briefly:
> From Thunderbird I got request
> 452 UID fetch 16,17:18,20:41,43:45,47,49 (UID RFC822.SIZE BODY.PEEK[])
> which is mapped to calls on MessageMapper.findInMailbox()
> findInMailbox: TYPE: RANGE UID: 16:18, Full
> *findInMailbox: TYPE: FROM UID: 19:-1, Full
> findInMailbox: TYPE: RANGE UID: 20:41, Full
> *findInMailbox: TYPE: FROM UID: 42:-1, Full
> findInMailbox: TYPE: RANGE UID: 43:45, Full
> *findInMailbox: TYPE: FROM UID: 46:-1, Full
> findInMailbox: TYPE: ONE UID: 47:47, Full
> *findInMailbox: TYPE: ONE UID: 48:48, Full
> findInMailbox: TYPE: ONE UID: 49:49, Full
> Those marked calls of method findInMailbox are completely unnecessary and
> should be avoided.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
