Hello Tellier, Thank you for your solutions and notes.
I will study the MailAddress object and try to modify it to support email subaddressing. It will take me some time to implement the changes. I plan to have them done in the middle of May. Thank you, Sergey On Fri, Apr 29, 2016 at 9:32 AM, Benoit Tellier <[email protected]> wrote: > Moreover, we should take advantage of this task to factorize code : > > We have two MailAddress classes : > > org.apache.mailet.MailAddress > org.apache.james.protocols.smtp.MailAddress; > > These two class have almost the same content (copy and paste ?), and > tests are only written for the mailet one. > > In my opinion, we must make smtp protocol depend on mailet api to reuse > MailAddress object across our projects and fight code duplication. > > Le 29/04/2016 à 09:06, Benoit Tellier a écrit : > > Hi Sergey, > > > > I had a look in the patch. I would rather modify the MailAddress object > > to handle tag. > > > > Why ? > > > > - With your solution, the information about the tag is lost after the > > mailet processing. > > - My mail server will only be able to handle mail Address tags if I > > configured the mailet and your handler. > > > > I would rather see a MailAddress object that extract the tag from the > > mail. Equality and other operations will not include the tag (achieving > > what you want) granting us this functionnality in a reusable fashion, > > and implemented in an object oriented way. > > > > Would this proposition satisfy you ? Can you create a ticket for this > > topic on JIRA ? (https://issues.apache.org/jira/browse/MAILET) > > > > And thank you so much for your contribution. It is definitely more than > > welcomed ! > > > > Cheers, > > > > Benoit > > > > Le 28/04/2016 à 22:56, Sergey Lysenkov a écrit : > >> Hello, > >> > >> Thank you for your help. > >> > >> I have done patch. Please see in attachment. > >> > >> > >> > >> On Thu, Apr 28, 2016 at 6:17 PM, Ioan Eugen Stan <[email protected] > >> <mailto:[email protected]>> wrote: > >> > >> Hello, > >> > >> Usually github is a read only git mirror of Apache repositories. > Meaning > >> you can't push, especially since you are not a committer. > >> > >> Read more here [1]. > >> > >> What you should do is either: > >> > >> 1. work on your clone and create a patch with git patch , submit via > >> email > >> 2. fork project on github, push your branch on your fork and issue a > >> pull request, then send email to list with PR. > >> > >> Any branch name is fine. > >> > >> > >> [1] http://www.apache.org/dev/git.html > >> > >> On 28.04.2016 17:57, Sergey Lysenkov wrote: > >> > Hello Antoine, > >> > > >> > Thank you for your reply. > >> > I faced out with problem. I can't push code to repository on > >> > https://github.com/apache/james-project > >> > > >> > I have got error: > >> > remote: Permission to apache/james-project.git denied to > lysenkovsts. > >> > fatal: unable to access > >> 'https://github.com/apache/james-project.git/': The > >> > requested URL returned error: 403 > >> > > >> > Can you help me to resolve this issue? > >> > > >> > Also I don't know what branch name will be correct for my code. On > >> my local > >> > repository I named branch as JAMES-subaddressing. What do you > >> think about > >> > that branch name? > >> > > >> > On Thu, Apr 28, 2016 at 3:57 PM, Antoine DUPRAT > >> <[email protected] <mailto:[email protected]>> > >> > wrote: > >> > > >> >> Hi, > >> >> > >> >> Thank you for using James. > >> >> We are really happy to receive contribution, you can create a > >> pull request > >> >> on GitHub: > >> >> https://github.com/apache/james-project > >> >> > >> >> Have a nice day, > >> >> Antoine Duprat > >> >> > >> >> > >> >> Hello All, > >> >>> > >> >>> Our team successfuly used James mail server for a project untile > >> we've got > >> >>> a requirement to support sub-addressing. It turned out that > >> James does not > >> >>> support a tag appended to the local part of email address (ex: > >> >>> [email protected] <mailto:joeuser%[email protected]>). > RFC > >> 5233, refers to this convention as > >> >>> sub-addressing, but it is also known as plus addressing or > tagged > >> >>> addressing. To resolve this issue our team have developed > >> >>> 'SubAddressingValidRcptHandler' which extends from > >> >>> 'org.apache.james.smtpserver.fastfail.ValidRcptHandler' class. > >> Also to > >> >>> find > >> >>> the right addressee by email address with sub-addressing we have > >> developed > >> >>> matcher 'SubAddressingMatcher'. > >> >>> > >> >>> I do not know if you have plans to implement the sub-addressing > >> support. I > >> >>> can send you our code for review and will be happy if our > >> changes save > >> >>> time > >> >>> for other developers who faced with the same issue as we had. > >> >>> > >> >>> Please let me know if that makes sense and which way I can send > >> the code > >> >>> for review. > >> >>> > >> >>> Thank you, > >> >>> Sergey Lysenkov > >> >>> > >> >>> > >> >> > >> >> > --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: [email protected] > >> <mailto:[email protected]> > >> >> For additional commands, e-mail: > [email protected] > >> <mailto:[email protected]> > >> >> > >> >> > >> > > >> > >> > --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> <mailto:[email protected]> > >> For additional commands, e-mail: [email protected] > >> <mailto:[email protected]> > >> > >> > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
