JAMES-2251 Switch to using Guava's Joiner
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/23b96909 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/23b96909 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/23b96909 Branch: refs/heads/master Commit: 23b9690968f472ff8fea89927ab01a98a0526aac Parents: 9c871fe Author: Daniel Trebbien <dtrebb...@gmail.com> Authored: Wed Dec 6 12:16:47 2017 -0600 Committer: Antoine Duprat <adup...@linagora.com> Committed: Tue Dec 12 09:47:38 2017 +0100 ---------------------------------------------------------------------- .../apache/james/transport/mailets/BayesianAnalysis.java | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/23b96909/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java ---------------------------------------------------------------------- diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java index 0888761..69845ca 100644 --- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java +++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java @@ -25,7 +25,6 @@ import java.io.StringReader; import java.sql.Connection; import java.text.DecimalFormat; import java.util.Collection; -import java.util.Iterator; import javax.inject.Inject; import javax.mail.MessagingException; @@ -43,6 +42,8 @@ import org.apache.mailet.base.RFC2822Headers; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import com.google.common.base.Joiner; + /** * <p> * Spam detection mailet using bayesian analysis techniques. @@ -370,15 +371,9 @@ public class BayesianAnalysis extends GenericMailet { return "null"; } - Iterator<MailAddress> iter = addresses.iterator(); StringBuilder sb = new StringBuilder(); sb.append('['); - for (int i = 0; iter.hasNext(); i++) { - if (i > 0) { - sb.append(", "); - } - sb.append(iter.next()); - } + Joiner.on(", ").appendTo(sb, addresses); sb.append(']'); return sb.toString(); } --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org