JAMES-2251 Avoid calling Collection.size() Avoiding Collection.size() is generally to be preferred because it might be slow.
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/0738899e Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/0738899e Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/0738899e Branch: refs/heads/master Commit: 0738899ee749b98166a50704660aad084b7bf7db Parents: aee6cc7 Author: Daniel Trebbien <dtrebb...@gmail.com> Authored: Mon Oct 30 11:57:23 2017 -0400 Committer: Antoine Duprat <adup...@linagora.com> Committed: Tue Dec 12 09:47:36 2017 +0100 ---------------------------------------------------------------------- .../org/apache/james/transport/mailets/BayesianAnalysis.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/0738899e/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java ---------------------------------------------------------------------- diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java index 2d9924b..0888761 100644 --- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java +++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/BayesianAnalysis.java @@ -374,10 +374,10 @@ public class BayesianAnalysis extends GenericMailet { StringBuilder sb = new StringBuilder(); sb.append('['); for (int i = 0; iter.hasNext(); i++) { - sb.append(iter.next()); - if (i + 1 < addresses.size()) { + if (i > 0) { sb.append(", "); } + sb.append(iter.next()); } sb.append(']'); return sb.toString(); --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
