This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 39c669ceb36eefeb605a8f640acaf36d320c0a23 Author: Tran Tien Duc <dt...@linagora.com> AuthorDate: Mon Jan 13 18:06:39 2020 +0700 [Refactoring] Remove unnecessary JMAPTestModule in webadmin-integration-test --- .../rabbitmq/RabbitMQAuthorizedEndpointsTest.java | 2 -- .../RabbitMQEventDeadLettersIntegrationTest.java | 2 -- ...stViewProjectionHealthCheckIntegrationTest.java | 23 ++++++++++++++++++++-- .../rabbitmq/RabbitMQJmapExtension.java | 4 ---- .../rabbitmq/RabbitMQJwtFilterIntegrationTest.java | 2 -- .../RabbitMQWebAdminServerIntegrationTest.java | 2 -- ...dminServerTaskSerializationIntegrationTest.java | 2 -- .../memory/MemoryAuthorizedEndpointsTest.java | 2 -- .../memory/MemoryJwtFilterIntegrationTest.java | 2 -- .../memory/MemoryUnauthorizedEndpointsTest.java | 2 -- .../MemoryWebAdminServerIntegrationTest.java | 2 -- 11 files changed, 21 insertions(+), 24 deletions(-) diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQAuthorizedEndpointsTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQAuthorizedEndpointsTest.java index c86974c..d054d55 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQAuthorizedEndpointsTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQAuthorizedEndpointsTest.java @@ -28,7 +28,6 @@ import org.apache.james.JamesServerExtension; import org.apache.james.junit.categories.BasicFeature; import org.apache.james.modules.AwsS3BlobStoreExtension; import org.apache.james.modules.RabbitMQExtension; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.integration.AuthorizedEndpointsTest; import org.apache.james.webadmin.integration.UnauthorizedModule; import org.apache.james.webadmin.integration.WebadminIntegrationTestModule; @@ -46,7 +45,6 @@ class RabbitMQAuthorizedEndpointsTest extends AuthorizedEndpointsTest { .extension(new RabbitMQExtension()) .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(CassandraRabbitMQJamesServerMain.MODULES) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new UnauthorizedModule()) .overrideWith(new WebadminIntegrationTestModule())) .build(); diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQEventDeadLettersIntegrationTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQEventDeadLettersIntegrationTest.java index a275005..18060c8 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQEventDeadLettersIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQEventDeadLettersIntegrationTest.java @@ -54,7 +54,6 @@ import org.apache.james.mailbox.model.MailboxPath; import org.apache.james.modules.AwsS3BlobStoreExtension; import org.apache.james.modules.MailboxProbeImpl; import org.apache.james.modules.RabbitMQExtension; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.probe.DataProbe; import org.apache.james.utils.DataProbeImpl; import org.apache.james.utils.WebAdminGuiceProbe; @@ -175,7 +174,6 @@ class RabbitMQEventDeadLettersIntegrationTest { .extension(new RetryEventsListenerExtension()) .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(CassandraRabbitMQJamesServerMain.MODULES) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule())) .build(); diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQFastViewProjectionHealthCheckIntegrationTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQFastViewProjectionHealthCheckIntegrationTest.java index 643e25d..a351ee5 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQFastViewProjectionHealthCheckIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQFastViewProjectionHealthCheckIntegrationTest.java @@ -19,11 +19,30 @@ package org.apache.james.webadmin.integration.rabbitmq; +import org.apache.james.CassandraExtension; +import org.apache.james.CassandraRabbitMQJamesServerMain; +import org.apache.james.DockerElasticSearchExtension; +import org.apache.james.GuiceJamesServer; +import org.apache.james.JamesServerBuilder; +import org.apache.james.JamesServerExtension; +import org.apache.james.modules.AwsS3BlobStoreExtension; +import org.apache.james.modules.RabbitMQExtension; +import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.integration.FastViewProjectionHealthCheckIntegrationContract; -import org.apache.james.webadmin.integration.rabbitmq.RabbitMQJmapExtension.JamesLifeCyclePolicy; +import org.apache.james.webadmin.integration.WebadminIntegrationTestModule; import org.junit.jupiter.api.extension.RegisterExtension; class RabbitMQFastViewProjectionHealthCheckIntegrationTest extends FastViewProjectionHealthCheckIntegrationContract { + @RegisterExtension - static RabbitMQJmapExtension rabbitMQJmapExtension = new RabbitMQJmapExtension(JamesLifeCyclePolicy.FOR_EACH_TEST); + static JamesServerExtension testExtension = new JamesServerBuilder() + .extension(new DockerElasticSearchExtension()) + .extension(new CassandraExtension()) + .extension(new AwsS3BlobStoreExtension()) + .extension(new RabbitMQExtension()) + .server(configuration -> GuiceJamesServer.forConfiguration(configuration) + .combineWith(CassandraRabbitMQJamesServerMain.MODULES) + .overrideWith(TestJMAPServerModule.limitToTenMessages()) + .overrideWith(new WebadminIntegrationTestModule())) + .build(); } diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJmapExtension.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJmapExtension.java index e6884ae..a6d8467 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJmapExtension.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJmapExtension.java @@ -18,8 +18,6 @@ ****************************************************************/ package org.apache.james.webadmin.integration.rabbitmq; -import static org.apache.james.modules.TestJMAPServerModule.LIMIT_TO_20_MESSAGES; - import java.io.IOException; import java.util.Optional; import java.util.function.Consumer; @@ -34,7 +32,6 @@ import org.apache.james.backends.rabbitmq.DockerRabbitMQSingleton; import org.apache.james.mailbox.extractor.TextExtractor; import org.apache.james.mailbox.store.search.PDFTextExtractor; import org.apache.james.modules.TestDockerESMetricReporterModule; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.modules.TestRabbitMQModule; import org.apache.james.modules.objectstorage.aws.s3.DockerAwsS3TestRule; import org.apache.james.server.core.configuration.Configuration; @@ -158,7 +155,6 @@ public class RabbitMQJmapExtension implements BeforeAllCallback, AfterAllCallbac return GuiceJamesServer.forConfiguration(configuration) .combineWith(CassandraRabbitMQJamesServerMain.MODULES) .overrideWith(binder -> binder.bind(TextExtractor.class).to(PDFTextExtractor.class)) - .overrideWith(TestJMAPServerModule.maximumMessages(LIMIT_TO_20_MESSAGES)) .overrideWith(new TestDockerESMetricReporterModule(elasticSearchRule.getDockerEs().getHttpHost())) .overrideWith(cassandra.getModule()) .overrideWith(elasticSearchRule.getModule()) diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJwtFilterIntegrationTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJwtFilterIntegrationTest.java index b756a98..d59f99b 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJwtFilterIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQJwtFilterIntegrationTest.java @@ -28,7 +28,6 @@ import org.apache.james.JamesServerExtension; import org.apache.james.jwt.JwtConfiguration; import org.apache.james.modules.AwsS3BlobStoreExtension; import org.apache.james.modules.RabbitMQExtension; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.authentication.AuthenticationFilter; import org.apache.james.webadmin.authentication.JwtFilter; import org.apache.james.webadmin.integration.JwtFilterIntegrationTest; @@ -45,7 +44,6 @@ class RabbitMQJwtFilterIntegrationTest extends JwtFilterIntegrationTest { .extension(new RabbitMQExtension()) .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(CassandraRabbitMQJamesServerMain.MODULES) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(binder -> binder.bind(AuthenticationFilter.class).to(JwtFilter.class)) .overrideWith(binder -> binder.bind(JwtConfiguration.class).toInstance(jwtConfiguration())) .overrideWith(new WebadminIntegrationTestModule())) diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerIntegrationTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerIntegrationTest.java index 179b9f7..5d04c9f 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerIntegrationTest.java @@ -38,7 +38,6 @@ import org.apache.james.backends.cassandra.versions.CassandraSchemaVersionManage import org.apache.james.junit.categories.BasicFeature; import org.apache.james.modules.AwsS3BlobStoreExtension; import org.apache.james.modules.RabbitMQExtension; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.integration.WebAdminServerIntegrationTest; import org.apache.james.webadmin.integration.WebadminIntegrationTestModule; import org.apache.james.webadmin.routes.AliasRoutes; @@ -65,7 +64,6 @@ class RabbitMQWebAdminServerIntegrationTest extends WebAdminServerIntegrationTes .extension(new RabbitMQExtension()) .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(CassandraRabbitMQJamesServerMain.MODULES) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule())) .build(); diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerTaskSerializationIntegrationTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerTaskSerializationIntegrationTest.java index 1b390af..3d587fc 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerTaskSerializationIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/RabbitMQWebAdminServerTaskSerializationIntegrationTest.java @@ -68,7 +68,6 @@ import org.apache.james.modules.AwsS3BlobStoreExtension; import org.apache.james.modules.EventDeadLettersProbe; import org.apache.james.modules.MailboxProbeImpl; import org.apache.james.modules.RabbitMQExtension; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.probe.DataProbe; import org.apache.james.task.TaskManager; import org.apache.james.utils.DataProbeImpl; @@ -104,7 +103,6 @@ class RabbitMQWebAdminServerTaskSerializationIntegrationTest { .extension(new RabbitMQExtension()) .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(CassandraRabbitMQJamesServerMain.MODULES) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule())) .build(); diff --git a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryAuthorizedEndpointsTest.java b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryAuthorizedEndpointsTest.java index 7e6d52d..42eb364 100644 --- a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryAuthorizedEndpointsTest.java +++ b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryAuthorizedEndpointsTest.java @@ -23,7 +23,6 @@ import org.apache.james.GuiceJamesServer; import org.apache.james.JamesServerBuilder; import org.apache.james.JamesServerExtension; import org.apache.james.MemoryJamesServerMain; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.integration.AuthorizedEndpointsTest; import org.apache.james.webadmin.integration.UnauthorizedModule; import org.apache.james.webadmin.integration.WebadminIntegrationTestModule; @@ -35,7 +34,6 @@ class MemoryAuthorizedEndpointsTest extends AuthorizedEndpointsTest { static JamesServerExtension jamesServerExtension = new JamesServerBuilder() .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(MemoryJamesServerMain.IN_MEMORY_SERVER_AGGREGATE_MODULE) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule()) .overrideWith(new UnauthorizedModule())) .build(); diff --git a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryJwtFilterIntegrationTest.java b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryJwtFilterIntegrationTest.java index 9fe4f1a..f62bd7b 100644 --- a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryJwtFilterIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryJwtFilterIntegrationTest.java @@ -24,7 +24,6 @@ import org.apache.james.JamesServerBuilder; import org.apache.james.JamesServerExtension; import org.apache.james.MemoryJamesServerMain; import org.apache.james.jwt.JwtConfiguration; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.authentication.AuthenticationFilter; import org.apache.james.webadmin.authentication.JwtFilter; import org.apache.james.webadmin.integration.JwtFilterIntegrationTest; @@ -37,7 +36,6 @@ class MemoryJwtFilterIntegrationTest extends JwtFilterIntegrationTest { static JamesServerExtension jamesServerExtension = new JamesServerBuilder() .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(MemoryJamesServerMain.IN_MEMORY_SERVER_AGGREGATE_MODULE) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule()) .overrideWith(binder -> binder.bind(AuthenticationFilter.class).to(JwtFilter.class)) .overrideWith(binder -> binder.bind(JwtConfiguration.class).toInstance(jwtConfiguration()))) diff --git a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryUnauthorizedEndpointsTest.java b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryUnauthorizedEndpointsTest.java index 83c29b6..7a8a1ca 100644 --- a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryUnauthorizedEndpointsTest.java +++ b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryUnauthorizedEndpointsTest.java @@ -23,7 +23,6 @@ import org.apache.james.GuiceJamesServer; import org.apache.james.JamesServerBuilder; import org.apache.james.JamesServerExtension; import org.apache.james.MemoryJamesServerMain; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.modules.vault.TestDeleteMessageVaultPreDeletionHookModule; import org.apache.james.webadmin.integration.UnauthorizedEndpointsTest; import org.apache.james.webadmin.integration.UnauthorizedModule; @@ -36,7 +35,6 @@ class MemoryUnauthorizedEndpointsTest extends UnauthorizedEndpointsTest { static JamesServerExtension jamesServerExtension = new JamesServerBuilder() .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(MemoryJamesServerMain.IN_MEMORY_SERVER_AGGREGATE_MODULE) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new TestDeleteMessageVaultPreDeletionHookModule()) .overrideWith(new UnauthorizedModule()) .overrideWith(new WebadminIntegrationTestModule())) diff --git a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryWebAdminServerIntegrationTest.java b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryWebAdminServerIntegrationTest.java index e92d1dc..323c77a 100644 --- a/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryWebAdminServerIntegrationTest.java +++ b/server/protocols/webadmin-integration-test/memory-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/memory/MemoryWebAdminServerIntegrationTest.java @@ -23,7 +23,6 @@ import org.apache.james.GuiceJamesServer; import org.apache.james.JamesServerBuilder; import org.apache.james.JamesServerExtension; import org.apache.james.MemoryJamesServerMain; -import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.webadmin.integration.WebAdminServerIntegrationTest; import org.apache.james.webadmin.integration.WebadminIntegrationTestModule; import org.junit.jupiter.api.extension.RegisterExtension; @@ -34,7 +33,6 @@ class MemoryWebAdminServerIntegrationTest extends WebAdminServerIntegrationTest static JamesServerExtension jamesServerExtension = new JamesServerBuilder() .server(configuration -> GuiceJamesServer.forConfiguration(configuration) .combineWith(MemoryJamesServerMain.IN_MEMORY_SERVER_AGGREGATE_MODULE) - .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule())) .build(); } \ No newline at end of file --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org