This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 1174725f5de7732f336edabe659b216b992e991c Author: Tran Tien Duc <dt...@linagora.com> AuthorDate: Mon Jan 13 14:13:05 2020 +0700 [Refactoring] Port FixingGhostMailboxTest to use distributed product --- .../test/java/org/apache/james/CassandraExtension.java | 13 +++++++++++++ .../integration/rabbitmq/FixingGhostMailboxTest.java | 18 ++++++++---------- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/server/container/guice/cassandra-guice/src/test/java/org/apache/james/CassandraExtension.java b/server/container/guice/cassandra-guice/src/test/java/org/apache/james/CassandraExtension.java index d2564f1..98dcadd 100644 --- a/server/container/guice/cassandra-guice/src/test/java/org/apache/james/CassandraExtension.java +++ b/server/container/guice/cassandra-guice/src/test/java/org/apache/james/CassandraExtension.java @@ -19,7 +19,10 @@ package org.apache.james; +import org.apache.james.util.Host; import org.junit.jupiter.api.extension.ExtensionContext; +import org.junit.jupiter.api.extension.ParameterContext; +import org.junit.jupiter.api.extension.ParameterResolutionException; import com.google.inject.Module; @@ -56,4 +59,14 @@ public class CassandraExtension implements GuiceModuleTestExtension { public void unpause() { cassandra.unpause(); } + + @Override + public boolean supportsParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException { + return parameterContext.getParameter().getType() == Host.class; + } + + @Override + public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException { + return cassandra.getHost(); + } } diff --git a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/FixingGhostMailboxTest.java b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/FixingGhostMailboxTest.java index 2e99453..44b0432 100644 --- a/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/FixingGhostMailboxTest.java +++ b/server/protocols/webadmin-integration-test/distributed-webadmin-integration-test/src/test/java/org/apache/james/webadmin/integration/rabbitmq/FixingGhostMailboxTest.java @@ -25,7 +25,6 @@ import static io.restassured.RestAssured.given; import static io.restassured.RestAssured.with; import static io.restassured.config.EncoderConfig.encoderConfig; import static io.restassured.config.RestAssuredConfig.newConfig; -import static org.apache.james.CassandraJamesServerMain.ALL_BUT_JMX_CASSANDRA_MODULE; import static org.apache.james.jmap.HttpJmapAuthentication.authenticateJamesUser; import static org.apache.james.jmap.LocalHostURIBuilder.baseUri; import static org.assertj.core.api.Assertions.assertThat; @@ -42,6 +41,7 @@ import java.io.IOException; import java.nio.charset.StandardCharsets; import org.apache.james.CassandraExtension; +import org.apache.james.CassandraRabbitMQJamesServerMain; import org.apache.james.DockerElasticSearchExtension; import org.apache.james.GuiceJamesServer; import org.apache.james.JamesServerBuilder; @@ -54,17 +54,17 @@ import org.apache.james.mailbox.MessageManager.AppendCommand; import org.apache.james.mailbox.cassandra.mail.task.MailboxMergingTask; import org.apache.james.mailbox.cassandra.table.CassandraMailboxPathV2Table; import org.apache.james.mailbox.exception.MailboxException; -import org.apache.james.mailbox.extractor.TextExtractor; import org.apache.james.mailbox.model.ComposedMessageId; import org.apache.james.mailbox.model.MailboxACL; import org.apache.james.mailbox.model.MailboxConstants; import org.apache.james.mailbox.model.MailboxId; import org.apache.james.mailbox.model.MailboxPath; import org.apache.james.mailbox.probe.ACLProbe; -import org.apache.james.mailbox.store.search.PDFTextExtractor; import org.apache.james.mime4j.dom.Message; import org.apache.james.modules.ACLProbeImpl; +import org.apache.james.modules.AwsS3BlobStoreExtension; import org.apache.james.modules.MailboxProbeImpl; +import org.apache.james.modules.RabbitMQExtension; import org.apache.james.modules.TestJMAPServerModule; import org.apache.james.server.CassandraProbe; import org.apache.james.task.TaskManager; @@ -102,15 +102,14 @@ class FixingGhostMailboxTest { private static final String ALICE_SECRET = "aliceSecret"; private static final String BOB_SECRET = "bobSecret"; - public static final CassandraExtension dockerCassandra = new CassandraExtension(); - @RegisterExtension static JamesServerExtension testExtension = new JamesServerBuilder() .extension(new DockerElasticSearchExtension()) - .extension(dockerCassandra) + .extension(new CassandraExtension()) + .extension(new AwsS3BlobStoreExtension()) + .extension(new RabbitMQExtension()) .server(configuration -> GuiceJamesServer.forConfiguration(configuration) - .combineWith(ALL_BUT_JMX_CASSANDRA_MODULE) - .overrideWith(binder -> binder.bind(TextExtractor.class).to(PDFTextExtractor.class)) + .combineWith(CassandraRabbitMQJamesServerMain.MODULES) .overrideWith(TestJMAPServerModule.limitToTenMessages()) .overrideWith(new WebadminIntegrationTestModule())) .build(); @@ -126,7 +125,7 @@ class FixingGhostMailboxTest { private RequestSpecification webadminSpecification; @BeforeEach - void setup(GuiceJamesServer server) throws Throwable { + void setup(GuiceJamesServer server, Host cassandraHost) throws Throwable { WebAdminGuiceProbe webAdminProbe = server.getProbe(WebAdminGuiceProbe.class); mailboxProbe = server.getProbe(MailboxProbeImpl.class); aclProbe = server.getProbe(ACLProbeImpl.class); @@ -148,7 +147,6 @@ class FixingGhostMailboxTest { .addUser(BOB, BOB_SECRET); accessToken = authenticateJamesUser(baseUri(jmapPort), Username.of(ALICE), ALICE_SECRET); - Host cassandraHost = dockerCassandra.getCassandra().getHost(); session = Cluster.builder() .withoutJMXReporting() .addContactPoint(cassandraHost.getHostName()) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org