By the way Tung, you forgot to mention you opened https://github.com/apache/james-project/pull/670 regarding this.
Can you open a JIRA ticket regarding this too? Regards, Benoit On 24/09/2021 14:33, btell...@apache.org wrote: > Hello Tung, > > +1 > > The feature is not usable as-is and requires extra development to be > used by people extending James. As such, I think we can remove this > unused piece of code. > > People extending James can still specify a custom behavior by > implementing their own MailboxACLResolver, back-porting the group > resolution logic if they need. > > My take is that it is likely unused and can be removed without impacting > anybody. > > Regards, > > Benoit > > On 24/09/2021 14:21, Tung Tran Van wrote: >> Hello all, >> >> I propose to remove `org.apache.james.mailbox.acl.GroupMembershipResolver` >> , `SimpleGroupMembershipResolver` and related implement. >> >> Reason: >> >> - Interface GroupMembershipResolver has only one implement is >> SimpleGroupMembershipResolver As the author's comment: "There is no >> persistence. You will get only what you add". >> >> And nowhere in James call to `.addMemberShip` method => `.isMember` always >> return FALSE. >> >> Remove the exuberancy code to make it simpler. >> >> >> Regards, >> >> Tung Tran Van >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org > For additional commands, e-mail: server-dev-h...@james.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
