Yes, I created a JIRA ticket https://issues.apache.org/jira/browse/JAMES-3654
On Fri, Sep 24, 2021 at 2:34 PM [email protected] <[email protected]> wrote: > By the way Tung, you forgot to mention you opened > https://github.com/apache/james-project/pull/670 regarding this. > > Can you open a JIRA ticket regarding this too? > > Regards, > > Benoit > > On 24/09/2021 14:33, [email protected] wrote: > > Hello Tung, > > > > +1 > > > > The feature is not usable as-is and requires extra development to be > > used by people extending James. As such, I think we can remove this > > unused piece of code. > > > > People extending James can still specify a custom behavior by > > implementing their own MailboxACLResolver, back-porting the group > > resolution logic if they need. > > > > My take is that it is likely unused and can be removed without impacting > > anybody. > > > > Regards, > > > > Benoit > > > > On 24/09/2021 14:21, Tung Tran Van wrote: > >> Hello all, > >> > >> I propose to remove > `org.apache.james.mailbox.acl.GroupMembershipResolver` > >> , `SimpleGroupMembershipResolver` and related implement. > >> > >> Reason: > >> > >> - Interface GroupMembershipResolver has only one implement is > >> SimpleGroupMembershipResolver As the author's comment: "There is no > >> persistence. You will get only what you add". > >> > >> And nowhere in James call to `.addMemberShip` method => `.isMember` > always > >> return FALSE. > >> > >> Remove the exuberancy code to make it simpler. > >> > >> > >> Regards, > >> > >> Tung Tran Van > >> > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Tung, Tran Van *Phone:* (+84) 35 757 6258 *Skype:* tung.tv202
