2009/8/21 Kelly O'Hair <[email protected]>: > Kelly O'Hair wrote: >> >> Still need reviewer ... >> >> 6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project >> >> >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/ >> >> Pretty harmless code cleanup on the tool used to generate >> some of the JDWP code for the debugger. > > The webrev has been updated. > > The field constantMap is now final. > > The throw in Main.java usage() is gone and use of usage() is now followed by > a simple return from main(). > > Thanks for the reviews from Andrew, Alan, and Tim. > > Let me know if this looks ok now. > > -kto >
Looks ok to me. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
