Re: Need reviewer - jdk7 jdwpgen, added netbeans project, fixed findbugs errors

[Kelly O'Hair]

swamy wrote:

Looks good to me.
In this file:

http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/make/netbeans/jdwpgen/nbproject/project.properties.html

  1 application.title=jdwpgen
  2 application.vendor=ohair

Shouldn't this be Sun Microsystems or ...

Strange, yeah, should be sun or something other than ohair, unless
someone turned me into a vendor recently... :^(

Thanks.

-kto

-Swamy


Andrew John Hughes wrote:

2009/8/21 Kelly O'Hair <kelly.oh...@sun.com>:

Kelly O'Hair wrote:

Still need reviewer ...

 6853636: Fix warnings in jdwpgen, add jdwpgen NetBeans project

http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-jdwpgen-6853636/webrev/

Pretty harmless code cleanup on the tool used to generate
some of the JDWP code for the debugger.

The webrev has been updated.

The field constantMap is now final.

The throw in Main.java usage() is gone and use of usage() is now followed by

a simple return from main().

Thanks for the reviews from Andrew, Alan, and Tim.

Let me know if this looks ok now.

-kto

Looks ok to me.