Re: review (S) for 6943485: JVMTI always on capabilities change code generation too much

[daniel . daugherty]

On 4/20/2010 4:39 PM, Tom Rodriguez wrote:

http://cr.openjdk.java.net/~never/6943485

Summary: thumbs up

I updated the bug comments with some code history stuff.


src/share/vm/c1/c1_Compilation.cpp
   No comments.

src/share/vm/c1/c1_Compilation.hpp
   No comments.

src/share/vm/c1/c1_GraphBuilder.cpp
   No comments.

src/share/vm/c1/c1_LinearScan.cpp
   No comments.

src/share/vm/c1/c1_globals.hpp
   No comments.

src/share/vm/ci/ciEnv.cpp
   No comments.

src/share/vm/ci/ciEnv.hpp
   No comments.

src/share/vm/opto/c2compiler.cpp
   So it's okay to EscapeAnalysis when redefining classes?

src/share/vm/opto/compile.cpp
   No comments.

src/share/vm/opto/compile.hpp
   No comments.

src/share/vm/opto/graphKit.cpp
   No comments.

src/share/vm/prims/jvmtiExport.cpp
   No comments.

src/share/vm/prims/jvmtiExport.hpp
   No comments.

src/share/vm/prims/jvmtiManageCapabilities.cpp
   In addition to can_generate_breakpoint_events, the
   can_generate_frame_pop_events should be queried also when
   setting can_access_local_variables.