Hi Nils,
I can be the sponsor for this one.
Here's my comments:
diagnosticFramework.cpp:77-79
why do you need:
77 if (_buffer[_cursor] == _delim) {
78 _cursor++;
79 }
When there's this loop just a few lines above:
64 while (_cursor < _len - 1 && _buffer[_cursor] == _delim) {
65 _cursor++;
66 }
diagnosticArgument.hpp:2
Copyright years need update
diagnosticArgument.cpp:2
Copyright years need update
diagnosticArgument:46
Why adding an empty line here?
diagnosticArgument:134:
Could you replace (str[idx] >= '0' && str[idx] <= '9') with
isdigit(str[idx]) ?
diagnosticArgument.cpp:212-242:
Could you follow Karen recommendation and re-use the atomull()
implementation? I think I sent you a webrev about this change.
diagnosticFramework.hpp:2
Copyright years need update
Fred
On 02/13/12 10:58 PM, Nils Loodin wrote:
Hey all!
The new diagnostic command parser needs some additional specializations for
time and bytes, here included.
Also a few fixes for crashes for some combinations of commandlines.
Tested by throwing a lot of different arguments on the parser, also by running
the tests in sun/tools/jcmd.
http://cr.openjdk.java.net/~nloodin/7145243/webrev.00/
I would also need a sponsor to get this in..
Regards
Nils Loodin
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
