Thank you Nils :-)
I had a question on the DCmdArgument<NanoTimeArgument> - I think I am not
reading
this correctly:
Couple of questions please:
1) What is this doing?
if (idx == len) {
143
// only accept missing unit if the value is 0
144
if (_value._time != 0) {
145
THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(),
146
"Integer parsing error nanotime value: unit required");
147
} else {
148
_value._nanotime = 0;
149
strcpy(_value._unit, "ns");
150
return;
I haven't seen the specification at this level of detail, but I thought that if
you entered a digit value with no units that you got ns by default - i.e. we
need to
be able to parse units, but they are not required.
2) What does this comment mean:
// WARNING StringArrayArgument can only be used as an option, it cannot be
// used as an argument with the DCmdParser
... DCmdArgument<StringArrayArgument*>
-- what can't you do with it more specifically please? Do you mean you can't
pass it as an argument to parse_value?
3) diagnosticFramework.cpp: copyright 2012NAME -- oops
thanks,
Karen
On Feb 14, 2012, at 12:33 PM, Nils Loodin wrote:
> Forgot an important point - the testing
>
> First I ran all the testing we have for the tracing framework that makes use
> of these commands.
> I have also debugged through with frivolous command lines to make sure we
> don't do anything bad, like crash.
> Also I've manually tried to use all the combinations of the command line
> arguments I can think of that should work, and that shouldn't.
>
> Regards
> Nils Loodin
>
> On Feb 14, 2012, at 18:29 , Nils Loodin wrote:
>
>> Thanks all for suggestions on improvements.
>> I have an updated webrev here:
>> http://cr.openjdk.java.net/~nloodin/7145243/webrev.01/
>>
>> Regards
>> Nils Loodin
>>
>> PS: Note - Frederic Parain has graciously taken upon himself to sponsor
>> this. Many thanks!
>>
>> DS
>>
>> On Feb 13, 2012, at 22:58 , Nils Loodin wrote:
>>
>>> Hey all!
>>>
>>> The new diagnostic command parser needs some additional specializations for
>>> time and bytes, here included.
>>> Also a few fixes for crashes for some combinations of commandlines.
>>>
>>> Tested by throwing a lot of different arguments on the parser, also by
>>> running the tests in sun/tools/jcmd.
>>>
>>> http://cr.openjdk.java.net/~nloodin/7145243/webrev.00/
>>>
>>> I would also need a sponsor to get this in..
>>>
>>> Regards
>>> Nils Loodin
>>
>
