Re: RFR: 6879063: SA should use hsdis for disassembly

[Yumin Qi]

This version of webrev diff is messed up. Please ignore it.
Will let you know when it is OK.

Thanks for the suggestion I will test on Windows and OS X.

Thanks
Yumin

On 2012/8/28 23:08, Staffan Larsen wrote:

Yumin,

The bsd makefiles are still not updated as far as I can see. I think this should be tested on OS X and Windows as well as Linux and Solaris before it goes in.

Thanks,
/Staffan

On 29 aug 2012, at 01:48, Yumin Qi <yumin...@oracle.com <mailto:yumin...@oracle.com>> wrote:

Hi, all

Updated with feedback suggestions. Please have a look again at the same link.

Thanks
Yumin




On 2012/8/27 14:07, Yumin Qi wrote:

Hi, all

  Can I have you code review of
  6879063: SA should use hsdis for disassembly

http://cr.openjdk.java.net/~minqi/6879063 <http://cr.openjdk.java.net/%7Eminqi/6879063/>

The SA has Java based disassemblers for x86 and sparc but amd64. Instead of porting to amd64 we should switch over to using hsdis for it like the JVM does. This requires a new entry point into hsdis, decode_instructions_virtual, which separates the address of the code being disassembled from the buffer containing the code. The existing uses of decode_instructions have been updated to use the new interface and SA Disassembler has Java native methods that call into hsdis and call back up to Java to perform the disassembly. Also changed makefile for hsdis build for both(i386/amd64).

All the old disassembler logic was deleted since it's incompatible with the new disassembly interface. Also deleted are dbx based SA interface and few other dead files.

  Tested by dumping full assembly from core files.

  Reviewed-by:
  Contributed-by: Tom R (never)

  Thanks
  Yumin Qi