Reviving the review process. I still need an official openjdk reviewer for this.
Thanks, -JB- On 12/24/2012 03:43 PM, shanliang wrote: > The fix looks OK for me, and I can be sponsor. > > If possible I think it is better to test the fix in an IPv6 machine. It > is said that IPv6 is enabled by default on windows7 > (http://pcuserinfo.com/how-to-enable-install-and-configure-ipv6-windows-7/), > but need to be installed on XP. > > Look at the JMXServiceURL, it contains the address at which the > connector server is found: > //[host[:port]][url-path] > we can specify a IPv6 host address here. For example ::1 equivalent to > IPv4 127.0.0.1 > > But I never do it. > > Shanliang > > > Jaroslav Bachorik wrote: >> Looking for reviewers and a sponsor. >> >> Webrev is available at >> http://cr.openjdk.java.net/~jbachorik/JDK-7199324/webrev.00 >> >> The issue is about the JMX client connection ID not being generated >> accordingly to the specification when including an IPv6 address. The >> specification states that in such case the address must be enclosed in >> square brackets. The current implementation, however, returns the plain >> numeric address, contradicting the specification. >> >> The fix simply checks for the presence of ":" character in the address >> part of the connection ID and escapes the address if necessary. Since >> the ":" can be present only in a numeric IPv6 address this check is >> sufficient. >> >> The change to test just covers for checking proper escaping - I am not >> sure how to force IPv6 to be used from the test; probably it is not >> possible. The test will check the IPv6 address escaping when and only >> when the system setup will cause the JMX client to connect over IPv6. >> >> Thanks, >> >> -JB- >> >
