But it's changing from stdout to stderr in the webrev. At least GNU believes [1] it should go to stdout. It make the output more'able.

Also, I am not sure if

  int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1;

really does what it intends to. Cannot remember the precedence order of all these operators. I would add parentheses.

Thanks
Max

[1] http://www.gnu.org/prep/standards/html_node/_002d_002dhelp.html

On 11/14/13, 17:38, Alan Bateman wrote:
On 14/11/2013 07:34, Staffan Larsen wrote:
Still looking for an official Review of this change.
This looks okay to me (I surprised we hadn't noticed the usage message
going to stderr before). Slightly different styles for if-the-else in
JStack but not too interesting. I guess we could use strings-in-switch
here if there are more options added.

-Alan

Reply via email to