Missed that one. I’ll fix it in the same way before pushing. /Staffan
On 14 Nov 2013, at 16:53, Peter Allwin <peter.all...@oracle.com> wrote: > Hi Staffan, > 84 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : > 1; > Looks like one more case of this. > > > Thanks! > /peter > > > On 14 Nov 2013, at 13:19, Staffan Larsen <staffan.lar...@oracle.com> wrote: > >> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ >> >> On 14 Nov 2013, at 13:12, Staffan Larsen <staffan.lar...@oracle.com> wrote: >> >>> >>> On 14 Nov 2013, at 10:46, Weijun Wang <weijun.w...@oracle.com> wrote: >>> >>>> Also, I am not sure if >>>> >>>> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; >>>> >>>> really does what it intends to. Cannot remember the precedence order of >>>> all these operators. I would add parentheses. >>> >>> Good point. I’ll add parentheses. >>> >>> /Staffan >> >