On 03/12/2013 11:53, Mattias Tobiasson wrote:
Hi,
I have updated the patch after the review.
webrev:
http://cr.openjdk.java.net/~ykantser/6461635/webrev.04/
Changes:
1. Removed BasicTests.sh from ProblemList
2. Use sun.tools.jar.Main to create jars.
3. Application.java uses try-with-resources.
4. Changed name of nested test class from Impl to TestMain.
I looks at the updated webrev and the changes look good.
One other opportunity for try-with-resources is in RunnerUtil.readFile,
I didn't notice this in previous round. Better still would be use
Files.readAllBytes to read the file in one call, or readAllLines if the
file may be composed of several lines. This is just a minor point so no
need to re-generate the webrev if you change anything here.
I see Staffan is going to sponsor this for you.
-Alan
