Re: RFR(XS): 8056994: sun/tools/jstatd/TestJstatdPortAndServer.java and sun/tools/jstatd/TestJstatdServer.java miss correct check of RMI server availability

[Jaroslav Bachorik]

Reviewed!

-JB-

On 09/01/2014 04:09 PM, Yekaterina Kantserova wrote:

Please find the updated webrev here:
http://cr.openjdk.java.net/~ykantser/8056994/webrev.01/

Thanks,
Katja



On 09/01/2014 03:47 PM, Jaroslav Bachorik wrote:

Hi Katja,

On 09/01/2014 02:04 PM, Yekaterina Kantserova wrote:

Hi,

Could I please have a review of this small fix.

webrev: http://cr.openjdk.java.net/~ykantser/8056994/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8056994

I would recommend moving the code from L154-157 before the start of
the while loop and simplify it with
`String remoteHost = serverName != null ? serverName : "JStatRemoteHost"`

Cheers,

-JB-

Thanks,
Katja