Katja, I would advice to put brackets in ll. 151 i.e.
String remoteHost = (serverName != null) ? serverName : "JStatRemoteHost"; -Dmitry On 2014-09-01 18:01, Yekaterina Kantserova wrote: > On 09/01/2014 03:47 PM, Jaroslav Bachorik wrote: >> Hi Katja, >> >> On 09/01/2014 02:04 PM, Yekaterina Kantserova wrote: >>> Hi, >>> >>> Could I please have a review of this small fix. >>> >>> webrev: http://cr.openjdk.java.net/~ykantser/8056994/webrev.00/ >>> bug: https://bugs.openjdk.java.net/browse/JDK-8056994 >> >> I would recommend moving the code from L154-157 before the start of >> the while loop and simplify it with >> `String remoteHost = serverName != null ? serverName : "JStatRemoteHost"` > > Ouch, has missed while loop. Thanks for pointing it out! Will fix. > > // Katja > >> >> Cheers, >> >> -JB- >> >>> >>> Thanks, >>> Katja >>> >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
