Hi Evgeniya,

On 6/11/2014 1:33 AM, Evgeniya Stepanova wrote:
Hi,

Please review changes for 8062536, the OpenJDK/jdk part of the JDK-8019361

bug: https://bugs.openjdk.java.net/browse/JDK-8062536
fix: http://cr.openjdk.java.net/~eistepan/8062536/webrev.00/

Problem: Some tests explicitly set GC and fail when another GC is set
outside

I don't see why you have done this for the

test/sun/tools/jps/TestJps*.java

tests. They don't set any GC flags.

Solution: Such tests marked with the jtreg tag "requires" to skip test
if there is a conflict

Just wondering: Does a skipped test get a .jtr file showing it was skipped; or does it only appear in the higher-level jtreg log?

Thanks,
David

Tested locally with different GC flags (-XX:+UseG1GC,
-XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep and without
any GC flag). Tests are being excluded as expected. No tests failed
because of the conflict.

Thanks,
Evgeniya Stepanova

//

Reply via email to