On 2/11/15 2:12 AM, Mikael Auno wrote:
On 2015-02-11 04:13, Chris Plummer wrote:
In general I think this looks very good. Simple and well-commented
code to follow. I am missing a test, though. Please look at the
hotspot/test/serviceability/dcmd set of tests.
Added.
Your test is based on DcmdUtil.java which was removed last week (see
[0]). If you pull new changes from hs-rt/hotspot, you'll see plenty of
tests using the new DCMD utility classes in testlibrary. Also, the new
tests are divided in different subdirectories depending on the commands,
so as your test exercises VM.class_hierarchy it should go in
.../dcmd/vm/ as opposed to just .../dcmd/.
Thanks,
Mikael
[0]
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/tip/test/serviceability/dcmd
Ok. I'll pull the latest hs-rt and update the test. Thanks for pointing
that out.
Chris
