Hi Alex,

On 25/04/2015 12:33 AM, Alexander Kulyakhtin wrote:
Hi,

Could I, please, have a review of this tests-only change:

https://bugs.openjdk.java.net/browse/JDK-8067013: Rename the 
com.oracle.java.testlibary package
Webrev: http://cr.openjdk.java.net/~akulyakh/8067013/webrev.00/index.html

The change renames com.oracle.java.testlibrary package to jdk.test.lib package:

I presume this is a first step towards fixing:

https://bugs.openjdk.java.net/browse/JDK-8075327 (merging the two test libraries) ?

The directory structure have been changed under the hotspot/test/testlibrary/ 
to provide for the package renaming,

Did you use "hg rename" for that? The webrev suggests not as it shows deleted and added files rather than moved ones.

Everywhere in the hotspot/test files import statements have been changed as 
needed.

Seems okay based on scanning through the patch.

Copyright dates will need updating in many cases.

Thanks,
David

Best regards,
Alex



Reply via email to