Hi Staffan, Thank you very much for the reviewing.
Best regards, Alex ----- Original Message ----- From: staffan.lar...@oracle.com To: alexander.kulyakh...@oracle.com Cc: david.hol...@oracle.com, hotspot-...@openjdk.java.net, serviceability-dev@openjdk.java.net Sent: Tuesday, April 28, 2015 6:09:55 PM GMT +03:00 Iraq Subject: Re: RFR: JDK-8067013: Rename the com.oracle.java.testlibary package Looks good! Thanks, /Staffan > On 28 apr 2015, at 15:09, Alexander Kulyakhtin > <alexander.kulyakh...@oracle.com> wrote: > > Hi, > > I've updated the webrev in accordance with David's comments. > > Could you, please, review the changes: > >> https://bugs.openjdk.java.net/browse/JDK-8067013: Rename the >> com.oracle.java.testlibary package >> Webrev: http://cr.openjdk.java.net/~akulyakh/8067013/webrev.01/index.html > > Best regards, > Alex > > > ----- Original Message ----- > From: alexander.kulyakh...@oracle.com > To: david.hol...@oracle.com, hotspot-...@openjdk.java.net > Cc: serviceability-dev@openjdk.java.net > Sent: Tuesday, April 28, 2015 2:08:54 PM GMT +03:00 Iraq > Subject: Re: RFR: JDK-8067013: Rename the com.oracle.java.testlibary package > > Hi David, > > Thank you very much for your comments. > >> I presume this is a first step towards fixing: >> https://bugs.openjdk.java.net/browse/JDK-8075327 (merging the two test >> libraries) ? > Yes, this is correct > >> Did you use "hg rename" for that? The webrev suggests not as it shows > No, I used hg add and hg delete. > I'm going to fix this now by doing hg rename > >> Copyright dates will need updating in many cases. > I'm going to update the copyrights > > I'll send out the updated webrev as soon as I'm done. > > Best regards, > Alex > > ----- Original Message ----- > From: david.hol...@oracle.com > To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net, > hotspot-...@openjdk.java.net > Sent: Monday, April 27, 2015 4:39:31 AM GMT +03:00 Iraq > Subject: Re: RFR: JDK-8067013: Rename the com.oracle.java.testlibary package > > Hi Alex, > > On 25/04/2015 12:33 AM, Alexander Kulyakhtin wrote: >> Hi, >> >> Could I, please, have a review of this tests-only change: >> >> https://bugs.openjdk.java.net/browse/JDK-8067013: Rename the >> com.oracle.java.testlibary package >> Webrev: http://cr.openjdk.java.net/~akulyakh/8067013/webrev.00/index.html >> >> The change renames com.oracle.java.testlibrary package to jdk.test.lib >> package: > > > >> The directory structure have been changed under the >> hotspot/test/testlibrary/ to provide for the package renaming, > > deleted and added files rather than moved ones. > >> Everywhere in the hotspot/test files import statements have been changed as >> needed. > > Seems okay based on scanning through the patch. > > Copyright dates will need updating in many cases. > > Thanks, > David > >> Best regards, >> Alex >> >> >>
