On 19/05/15 15:39, Jaroslav Bachorik wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8080663
Webrev: http://cr.openjdk.java.net/~jbachorik/8080663/webrev.00
The title says it all. This enhancement is about replacing the arbitrary
reflection based code with a cleaner approach based on
sun.misc.SharedSecrets class.
Hi Jaroslav,
The logic looks good - but I notice the webrev has no test.
I would be surprised if there weren't a test somewhere that tests
the MXBean OpenType mapping with @ConstructorProperties - so I'd
suggest at least finding that test and adding @bug 8080663 to it
(and then also adding the noreg-existing keyword to 8080663)
best regards,
-- daniel
Thanks,
-JB-
