> On May 25, 2015, at 2:34 AM, Jaroslav Bachorik <jaroslav.bacho...@oracle.com> 
> wrote:
> 
> 
> Webrev with the merged accessor interface: 
> http://cr.openjdk.java.net/~jbachorik/8080663/webrev.01
> 
> 
>> 
>> Can you add a regression for this, if not exist, as Daniel points out?
> 
> There is a bunch of tests exercising the proper handling of 
> @ConstructorAnnotationProperties - I added this issue number to the list of 
> bug ids. Doesn't really seem to be worth adding a separate regtest.

Since there are existing regression tests exercising @CP and Introspector, this 
is well covered then (it wasn’t clear to me where these existing tests are and 
hence my comment). 

webrev.01 looks good to me.  Nit: JavaBeansAccessor and JavaBeansAccess - in 
the javadoc of getConstructorPropertiesValue method, <b>value</b> and 
<b>null</b>  may be more appropriate to use {@code …}

Mandy

Reply via email to