We could repeat retrying until the test harness timeout, but add a sleep is definitively useful between retrying.
Shanliang > On 23 Nov 2015, at 12:32, Daniel Fuchs <[email protected]> wrote: > > Hi Alexander, > > This looks a bit dangerous to me - it could create a busy loop > if for some reason the connection can never go through. > > I would suggest retrying only once (or retrying a fixed number > of times) - and possibly introducing a small delay (Thread.sleep) > before retrying. > > best regards, > > -- daniel > > On 23/11/15 12:19, Alexander Kulyakhtin wrote: >> Hi, >> >> Could you, please, review this small, test-only, change: >> >> CR: https://bugs.openjdk.java.net/browse/JDK-8143121 >> Webrev: >> http://cr.openjdk.java.net/~akulyakh/8143121/test/javax/management/remote/mandatory/loading/MethodResultTest.java.udiff.html >> >> The precondition for this test is a JMXConnector having established a >> successful connection. >> On some environments the test sometimes can not connect at the first >> attempt, because the target application is not yet ready. >> We are changing the test so that it tries to connect again if it gets >> IOException during the connection. >> >> Best regards, >> Alexander >> >
