Hi Alexander,
Looks good to me :-)
I like the:
System.out.println("Connection error. Retrying after delay...");
which will help diagnose if something more serious is causing
this failure: if we see 100th of them then I guess it will mean that the
test needs further debugging to get at the connection failure
root cause (would probably point at some MT race condition or
something...)
best regards,
-- daniel
On 23/11/15 14:18, Alexander Kulyakhtin wrote:
Hi,
As Daniel has suggested, I've updated the webrev introducing a 3 sec pause
between connection retries,
CR: https://bugs.openjdk.java.net/browse/JDK-8143121
Webrev:
http://cr.openjdk.java.net/~akulyakh/8143121_02/test/javax/management/remote/mandatory/loading/MethodResultTest.java.udiff.html
Best regards,
Alexander
----- Original Message -----
From: daniel.fu...@oracle.com
To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net
Sent: Monday, November 23, 2015 2:32:27 PM GMT +03:00 Iraq
Subject: Re: RFR: 8143121:
javax/management/remote/mandatory/loading/MethodResultTest.java fails
intermittently
Hi Alexander,
This looks a bit dangerous to me - it could create a busy loop
if for some reason the connection can never go through.
I would suggest retrying only once (or retrying a fixed number
of times) - and possibly introducing a small delay (Thread.sleep)
before retrying.
best regards,
-- daniel
On 23/11/15 12:19, Alexander Kulyakhtin wrote:
Hi,
Could you, please, review this small, test-only, change:
CR: https://bugs.openjdk.java.net/browse/JDK-8143121
Webrev:
http://cr.openjdk.java.net/~akulyakh/8143121/test/javax/management/remote/mandatory/loading/MethodResultTest.java.udiff.html
The precondition for this test is a JMXConnector having established a
successful connection.
On some environments the test sometimes can not connect at the first attempt,
because the target application is not yet ready.
We are changing the test so that it tries to connect again if it gets
IOException during the connection.
Best regards,
Alexander
